-
Notifications
You must be signed in to change notification settings - Fork 2.7k
Update opentelemetry-collector version #38462
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Matthew Sainsbury <[email protected]>
Signed-off-by: Matthew Sainsbury <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@songy23 do you have a recommendation on how to fix this? It's my first time doing this and expected that the two make commands would mostly select the right versions |
Looking at the diffs you can do a simple find and replace in all go.mod: (IDK if there is an easier way, working with update-otel has always been a pain for me) |
@mattsains I'm also surprised that |
I tried the updates suggested by @songy23 and the script just reverted the change, so I just let the script run and commit that, hopefully that's good? |
Description
I ran
make genotelcontribcol && make update-otel
to generate this PR. I also added some manual changes to opampsupervisor to update a reference that was renamed. This should fix the contrib matrix testsFixes #38459