Skip to content

Fixes issues related to TLS #37675

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 6 commits into from
Closed

Fixes issues related to TLS #37675

wants to merge 6 commits into from

Conversation

sonalgaud12
Copy link
Contributor

Description

Fixes the issue where TLS settings were not being applied correctly for Unix socket connections to a containerd daemon. The HTTP connection layer was assuming the connection was over HTTP, causing malformed responses. This change correctly applies the TLS configuration and ensures secure connections.

Link to tracking issue

Fixes #33557

@sonalgaud12 sonalgaud12 requested a review from a team as a code owner February 4, 2025 14:13
@github-actions github-actions bot requested a review from jamesmoessis February 4, 2025 14:14
@sonalgaud12 sonalgaud12 changed the title Fixes two issues related to TLS Fixes issues related to TLS Feb 4, 2025
crobert-1
crobert-1 reviewed Feb 4, 2025
View reviewed changes
Copy link
Member

@crobert-1 crobert-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should add some testing with this change to ensure it's working as expected 👍

@sonalgaud12 sonalgaud12 closed this Feb 7, 2025
@sonalgaud12 sonalgaud12 reopened this Feb 7, 2025
@sonalgaud12
Copy link
Contributor Author

Requesting review @jamesmoessis @crobert-1

@crobert-1
Copy link
Member

From failing checks:

go: updates to go.mod needed; to update it:
	go mod tidy

@sonalgaud12
Copy link
Contributor Author

From failing checks:

go: updates to go.mod needed; to update it:
	go mod tidy

Corrected

@sonalgaud12 sonalgaud12 closed this by deleting the head repository Feb 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fatsheep9146 fatsheep9146 Awaiting requested review from fatsheep9146 fatsheep9146 is a code owner automatically assigned from open-telemetry/collector-contrib-approvers

@jamesmoessis jamesmoessis Awaiting requested review from jamesmoessis

@crobert-1 crobert-1 Awaiting requested review from crobert-1

Assignees

@crobert-1 crobert-1

Labels
receiver/dockerstats
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[receiver/dockerstatsreceiver] Does not support setting TLS settings
3 participants
@sonalgaud12 @crobert-1 @jamesmoessis