[processor/attributes] validate metrics configuration parameters before processing #37435
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odubajDT
commented
Jan 23, 2025
odubajDT
commented
Jan 23, 2025
odubajDT
commented
Jan 23, 2025
github-actions
bot
added
internal/filter
processor/attributes
odubajDT
force-pushed
the
fix-metric-validation
branch
from
a501483 to
47af88a
Compare
odubajDT
commented
Jan 23, 2025
| if len(mp.MetricNames) > 0 { | ||
| return errors.New("metric_names should not be specified for trace spans") | ||
| } | ||
|
|
There was a problem hiding this comment.
According to the documentation, metric_names should be allowed only for metrics
odubajDT
commented
Jan 23, 2025
| @@ -176,7 +182,7 @@ func (mp *MatchProperties) ValidateForSpans() error { | |||
|
|
|||
| // ValidateForLogs validates properties for logs. | |||
| func (mp *MatchProperties) ValidateForLogs() error { | |||
| if len(mp.SpanNames) > 0 || len(mp.Services) > 0 || len(mp.SpanKinds) > 0 { | |||
| if len(mp.SpanNames) > 0 || len(mp.Services) > 0 || len(mp.SpanKinds) > 0 || len(mp.MetricNames) > 0 { | |||
There was a problem hiding this comment.
According to the documentation, metric_names should be allowed only for metrics
odubajDT
commented
Jan 23, 2025
| @@ -193,8 +193,8 @@ must be specified with a non-empty value for a valid configuration. The `log_bod | |||
| - For logs, one of `log_bodies`, `log_severity_texts`, `log_severity_number`, `attributes`, `resources` | |||
| or `libraries` must be specified with a non-empty value for a valid configuration. The `span_names`, | |||
| `span_kinds`, `metric_names` and `services` fields are invalid. | |||
| - For metrics, `metric_names` must be specified with a valid non-empty value for | |||
| a valid configuration. The `span_names`, `span_kinds`, `resources`, `log_bodies`, `log_severity_texts`, | |||
| - For metrics, one of `metric_names` or `resources` must be specified with a valid non-empty value for | |||
There was a problem hiding this comment.
resources are valid for metrics, see ResourceAttributes in the creation of MetricMatchProperties from MatchProperties
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
not stale |
odubajDT
force-pushed
the
fix-metric-validation
branch
from
48541aa to
d3c8021
Compare
evan-bradley
reviewed
Mar 3, 2025
…re processing Signed-off-by: odubajDT <[email protected]>
Signed-off-by: odubajDT <[email protected]>
Signed-off-by: odubajDT <[email protected]>
Signed-off-by: odubajDT <[email protected]>
odubajDT
force-pushed
the
fix-metric-validation
branch
from
4c01127 to
801cd1b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add validation for metrics-only configuration parameters
Link to tracking issue
Fixes #36077