Skip to content

[exporter/prometheusremotewrite] feat: prom rw exporter add support for rw2 #35888

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 114 commits into
base: main
Choose a base branch
from

Conversation

jmichalek132
Copy link
Contributor

@jmichalek132 jmichalek132 commented Oct 20, 2024

Description

Draft PR for adding rw2 support in the prometheus remote write exporter.
Very much a draft, not full implementation of the spec with a lot of code duplication and no tests WIP.

TODO:

  • changelog entry
  • feature flag on top of config options
  • rip out batching for now
  • enum instead of bool for RW2
  • update exporter readme
  • Validate supported enum value set
  • Check for TODOs
  • unit tests
  • going over the spec and making changes to be rw2 compliant -> follow up PR
  • try to reduce duplicate code

Link to tracking issue #33661

Fixes

Testing

Documentation

@github-actions github-actions bot added the Stale label Dec 31, 2024
@dashpole dashpole removed the Stale label Jan 6, 2025
Copy link
Contributor

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Jan 21, 2025
Copy link
Contributor

github-actions bot commented Feb 5, 2025

Closed as inactive. Feel free to reopen if this PR is still being worked on.

@ArthurSens ArthurSens reopened this May 2, 2025
@jmichalek132 jmichalek132 requested a review from bwplotka May 2, 2025 16:30
@github-actions github-actions bot removed the request for review from bwplotka May 2, 2025 16:30
@jmichalek132 jmichalek132 requested a review from bwplotka May 2, 2025 16:31
@github-actions github-actions bot removed the Stale label May 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants