[chore] Fix TestConnectorConsume/incomplete_traces_with_virtual_server_span failures on Windows #34798
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ailures on Windows
crobert-1
approved these changes
Aug 21, 2024
jpkrohling
requested changes
Aug 22, 2024
jpkrohling
approved these changes
Aug 22, 2024
atoulme
approved these changes
Aug 22, 2024
Fair, me neither, the goal is to get Windows CI reliably passing. I will open an follow up issue so we can eventually remove the sleep. |
crobert-1
added
the
ready to merge
|
Added |
pjanotti
deleted the
fix-servicegraphconnector-TestConnectorConsume-on-windows
branch
f7o
pushed a commit
to f7o/opentelemetry-collector-contrib
that referenced
this pull request
Sep 12, 2024
…r_span failures on Windows (open-telemetry#34798) **Description:** The failure is due to similar case as explained at open-telemetry#32715 (comment) This is a quick fix that just adds a delay to ensure that the test is passing on Windows. **Link to tracking Issue:** Fixes open-telemetry#34792 **Testing:** Local Windows test run. **Documentation:** N/A
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
The failure is due to similar case as explained at #32715 (comment)
This is a quick fix that just adds a delay to ensure that the test is passing on Windows.
Link to tracking Issue:
Fixes #34792
Testing:
Local Windows test run.
Documentation:
N/A