Skip to content

[receiver/oracle] use metadata.Type for scraper ID #31504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 29, 2024

Conversation

atoulme
Copy link
Contributor

@atoulme atoulme commented Feb 29, 2024

Description:
Use metadata.Type for the scraper id to avoid invalid scraper IDs.

Link to tracking Issue:
Fixes #31457

@crobert-1
Copy link
Member

@atoulme Can you update the PR description?

Fixes #31501

Should be:

Fixes #31457

@dmitryax dmitryax merged commit c02221e into open-telemetry:main Feb 29, 2024
@github-actions github-actions bot added this to the next release milestone Feb 29, 2024
@atoulme
Copy link
Contributor Author

atoulme commented Feb 29, 2024

sorry about that and thanks for fixing the issue link

@atoulme atoulme deleted the oracledb_scraper_id branch February 29, 2024 20:24
XinRanZhAWS pushed a commit to XinRanZhAWS/opentelemetry-collector-contrib that referenced this pull request Mar 13, 2024
…31504)

**Description:** 
Use metadata.Type for the scraper id to avoid invalid scraper IDs.

**Link to tracking Issue:**
Fixes
open-telemetry#31457
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

receivers/oracledb conflates IDs with Types
4 participants