[exporter/file] Refactor to keep the file exporter inside start/stop lifecycle #31495
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atoulme
force-pushed
the
fileexporter_lifecycle
branch
4 times, most recently
from
7b21f04 to
8ee39de
Compare
|
PTAL at the linter failures |
|
@atingchen PTAL |
atoulme
force-pushed
the
fileexporter_lifecycle
branch
from
8ee39de to
37cb0cb
Compare
dmitryax
approved these changes
Feb 29, 2024
|
Merging to unblock the failing build |
XinRanZhAWS
pushed a commit
to XinRanZhAWS/opentelemetry-collector-contrib
that referenced
this pull request
Mar 13, 2024
…lifecycle (open-telemetry#31495) **Description:** Scope the behavior of the fileexporter to its lifecycle, so it is safe to shut it down or restart it. **Link to tracking Issue:** Fixes open-telemetry#31494
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Scope the behavior of the fileexporter to its lifecycle, so it is safe to shut it down or restart it.
Link to tracking Issue:
Fixes #31494