[loadbalancingexporter] Set the default otlp port 4317 in factory and unit test #31425
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atmask
force-pushed
the
loadbalancingexporter-otlp-port
branch
from
937cd4f to
52bb363
Compare
andrzej-stencel
approved these changes
Feb 27, 2024
TylerHelmuth
approved these changes
Feb 27, 2024
|
Before I remove the changelog entry can this PR get labelled with the "Skip Changelog" so that the checks do not fail |
atmask
force-pushed
the
loadbalancingexporter-otlp-port
branch
from
ddb5eb4 to
23a5c41
Compare
… and unit test data to pass otlpexporter config validation from issue open-telemetry#9505 in otel-collector
atmask
force-pushed
the
loadbalancingexporter-otlp-port
branch
from
a6f7043 to
ff1e974
Compare
XinRanZhAWS
pushed a commit
to XinRanZhAWS/opentelemetry-collector-contrib
that referenced
this pull request
Mar 13, 2024
… unit test (open-telemetry#31425) **Description:** As described in the otel-collector [issue 9505](open-telemetry/opentelemetry-collector#9505), the otlpexporter does not function correctly if no port is defined. To resolve this, the otlp config validation has been updated to fail fast when the endpoint within an otlp config does not have a port specified. The loadbalancingexporter config has the otlp exporter config as a dependency, however, the loadbalancing exporter does not define a port on the otlpexporter config in two places: - default config from factory - testdata contents This is currently a blocker to the contrib tests for the [PR](open-telemetry/opentelemetry-collector#9632) to resolve issue 9505 Relates to: open-telemetry/opentelemetry-collector#9523 open-telemetry#31371 open-telemetry#31381 **Link to tracking Issue:** otel-collector-contrib: [issue 31426](open-telemetry#31426) Arises from otel-collector [issue 9505](open-telemetry/opentelemetry-collector#9505) **Testing:** Used `replace` to test loadbalancingexporter changes pass tests successfully when using the otlpexporter changes from [PR](open-telemetry/opentelemetry-collector#9632)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
As described in the otel-collector issue 9505, the otlpexporter does not function correctly if no port is defined. To resolve this, the otlp config validation has been updated to fail fast when the endpoint within an otlp config does not have a port specified.
The loadbalancingexporter config has the otlp exporter config as a dependency, however, the loadbalancing exporter does not define a port on the otlpexporter config in two places:
This is currently a blocker to the contrib tests for the PR to resolve issue 9505
Relates to:
open-telemetry/opentelemetry-collector#9523
#31371
#31381
Link to tracking Issue:
otel-collector-contrib: issue 31426
Arises from otel-collector issue 9505
Testing: Used
replaceto test loadbalancingexporter changes pass tests successfully when using the otlpexporter changes from PR