Skip to content

[receiver/haproxy] Failing test Test_scraper_readStatsWithIncompleteValues #38860

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
crobert-1 opened this issue Mar 21, 2025 · 12 comments
Open

[receiver/haproxy] Failing test Test_scraper_readStatsWithIncompleteValues #38860

crobert-1 opened this issue Mar 21, 2025 · 12 comments
Labels
ci-cd CI, CD, testing, build issues os:windows receiver/haproxy

Comments

@crobert-1
Copy link
Member

Component(s)

receiver/haproxy

Describe the issue you're reporting

Failing action link

Failure output:

Running target 'test' in module 'receiver/haproxyreceiver' as part of group 'receiver-1'
C:/mingw64/bin/make --no-print-directory -C receiver/haproxyreceiver test
D:/a/opentelemetry-collector-contrib/opentelemetry-collector-contrib/.tools/gotestsum --rerun-fails=1 --packages="./..." -- -race -timeout 600s -parallel 4 --tags=""
✖  . (167ms)
✓  internal/metadata (1.221s)

DONE 26 tests, 1 failure in 4.926s

✖  . (54ms)

=== Failed
=== FAIL: . Test_scraper_readStatsWithIncompleteValues (0.00s)
    scraper_test.go:[70](https://github.com/open-telemetry/opentelemetry-collector-contrib/actions/runs/13994266059/job/39185307310?pr=38852#step:8:71): 
        	Error Trace:	D:/a/opentelemetry-collector-contrib/opentelemetry-collector-contrib/receiver/haproxyreceiver/scraper_test.go:70
        	Error:      	Received unexpected error:
        	            	listen unix C:\Users\RUNNER~1\AppData\Local\Temp\Test_scraper_readStatsWithIncompleteValues2311702124\001\testhaproxy.sock: bind: invalid argument
        	Test:       	Test_scraper_readStatsWithIncompleteValues

=== FAIL: . Test_scraper_readStatsWithIncompleteValues (re-run 1) (0.00s)
    scraper_test.go:70: 
        	Error Trace:	D:/a/opentelemetry-collector-contrib/opentelemetry-collector-contrib/receiver/haproxyreceiver/scraper_test.go:70
        	Error:      	Received unexpected error:
        	            	listen unix C:\Users\RUNNER~1\AppData\Local\Temp\Test_scraper_readStatsWithIncompleteValues1541[74](https://github.com/open-telemetry/opentelemetry-collector-contrib/actions/runs/13994266059/job/39185307310?pr=38852#step:8:75)9157\001\testhaproxy.sock: bind: invalid argument
        	Test:       	Test_scraper_readStatsWithIncompleteValues
@crobert-1 crobert-1 added ci-cd CI, CD, testing, build issues needs triage New item requiring triage labels Mar 21, 2025
@github-actions GitHub Actions
Copy link
Contributor

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@crobert-1
Copy link
Member Author

+1 freq: https://github.com/open-telemetry/opentelemetry-collector-contrib/actions/runs/13994266059/job/39185307818?pr=38852

@crobert-1
Copy link
Member Author

+1 freq: https://github.com/open-telemetry/opentelemetry-collector-contrib/actions/runs/13992648627/job/39179904862

@crobert-1
Copy link
Member Author

+1 freq: https://github.com/open-telemetry/opentelemetry-collector-contrib/actions/runs/13992648627/job/39179906125

@atoulme atoulme removed the needs triage New item requiring triage label Mar 21, 2025
@atoulme
Copy link
Contributor

atoulme commented Mar 21, 2025

Guessing this is because the path is too long, or sockets and Windows don't work well.

@crobert-1
Copy link
Member Author

+1 freq: https://github.com/open-telemetry/opentelemetry-collector-contrib/actions/runs/13998151935/job/39198281753?pr=38862

@crobert-1
Copy link
Member Author

+1 freq: https://github.com/open-telemetry/opentelemetry-collector-contrib/actions/runs/13998151935/job/39198282386?pr=38862

@crobert-1
Copy link
Member Author

+1 freq: https://github.com/open-telemetry/opentelemetry-collector-contrib/actions/runs/13998581114/job/39199639881

@crobert-1
Copy link
Member Author

+1 freq: https://github.com/open-telemetry/opentelemetry-collector-contrib/actions/runs/13998581114/job/39199640483

@crobert-1
Copy link
Member Author

This is now failing every time, from what I'm seeing.

@crobert-1
Copy link
Member Author

First failure was after #38834 was merged, it's failed every time since. The PR moved from using a set path for a temporary test dir (os.MkdirTemp), to using t.TempDir. As Antoine pointed out with path lengths, this might be causing the issue.

I think for now we skip the test on Windows and follow up after on how to get it working properly.

This was referenced Mar 21, 2025
Merged
Merged
atoulme pushed a commit that referenced this issue Mar 21, 2025
@crobert-1
[chore][receiver/haproxy] Skip test on Windows for now (#38866)
43d926c 
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description
This is a temporary skip to get `main` green.

<!-- Issue number (e.g. #1234) or full URL to issue, if applicable. -->
#### Link to tracking issue

#38860

<!--Describe what testing was performed and which tests were added.-->
#### Testing

<!--Describe the documentation added.-->
#### Documentation

<!--Please delete paragraphs that you did not use before submitting.-->
This was referenced Mar 23, 2025
Closed
Closed
@github-actions github-actions bot mentioned this issue Mar 25, 2025
Closed
@songy23
Copy link
Member

songy23 commented Mar 26, 2025

Another hit: http://github.com/open-telemetry/opentelemetry-collector-contrib/actions/runs/14088963722/job/39460483617 not the exact same test but in the same component

Fiery-Fenix pushed a commit to Fiery-Fenix/opentelemetry-collector-contrib that referenced this issue Apr 24, 2025
@crobert-1 @Fiery-Fenix
[chore][receiver/haproxy] Skip test on Windows for now (open-telemetr…
03a56a5 
…y#38866)

<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description
This is a temporary skip to get `main` green.

<!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. -->
#### Link to tracking issue

open-telemetry#38860

<!--Describe what testing was performed and which tests were added.-->
#### Testing

<!--Describe the documentation added.-->
#### Documentation

<!--Please delete paragraphs that you did not use before submitting.-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
ci-cd CI, CD, testing, build issues os:windows receiver/haproxy
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@atoulme @songy23 @crobert-1