Resolve the logs/traces sampling priority discrepancy in probabilistic sampler processor

[jmacd]

Component(s)

processor/probabilisticsampler

What happened?

Description

See https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/main/processor/probabilisticsamplerprocessor/README.md#sampling-priority

Steps to Reproduce

This is a historical conflict.

Expected Result

The logs priority mechanism has proven useful because it allows OTTL transforms to configure sampling probabilities ahead of this processor, which simply does the math.

Actual Result

In traces, the sampling priority mechanism forces a pass-through, instead of overriding the sampling probability (as done in logs).

See #36876 (comment)

This calls for adding a feature flag to change how traces sampling_priority behavior works, at least that is the solution I would prefer.

Collector version

v0.120.0

Environment information

Environment

OS: (e.g., "Ubuntu 20.04")
Compiler(if manually compiled): (e.g., "go 14.2")

OpenTelemetry Collector configuration

Log output

Additional context

No response

[github-actions]

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.