Skip to content

Dynamic topic for googlecloudpubsub exporter #33547

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
JakubDaleki opened this issue Jun 13, 2024 · 9 comments
Open

Dynamic topic for googlecloudpubsub exporter #33547

JakubDaleki opened this issue Jun 13, 2024 · 9 comments

Comments

@JakubDaleki
Copy link

JakubDaleki commented Jun 13, 2024

Component(s)

exporter/googlecloudpubsub

Is your feature request related to a problem? Please describe.

Different logs (for example from different files) should be written to different topics on GCP PubSub. Current implementation allows only to specify one destination topic in static yaml config.

Describe the solution you'd like

I want to add a new flag to config topic_from_attribute. If set to true each log should be sent to a topic specified in Attribute gcp.topic of a LogRecord. If attribute is not present or is in invalid format logs should be sent to default topic specified in the topic field.

My PR showing changes needed to obtain this mechanism: https://github.com/open-telemetry/opentelemetry-collector-contrib/pull/33545/files

Describe alternatives you've considered

No response

Additional context

No response

@JakubDaleki JakubDaleki added enhancement New feature or request needs triage New item requiring triage labels Jun 13, 2024
Copy link
Contributor

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

Copy link
Contributor

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions github-actions bot added the Stale label Aug 13, 2024
@JakubDaleki
Copy link
Author

/label exporter/googlecloudpubsub discussion-needed

Copy link
Contributor

Pinging code owners for exporter/googlecloudpubsub: @alexvanboxel. See Adding Labels via Comments if you do not have permissions to add labels yourself.

Copy link
Contributor

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@alexvanboxel
Copy link
Contributor

alexvanboxel commented Jan 9, 2025

This can be considered, but first ordering will be added. This certainly will have an impact on the ACL's the service account needs. Before starting, I would review all the same classes of transport receiver/exporters that they have feature parity.

@JakubDaleki
Copy link
Author

Thanks for your response @alexvanboxel. Is there any active thread to track progress of ordering feature so I can start working on this once ordering is added? If the work has not been started yet, I could contribute there as well.

@alexvanboxel
Copy link
Contributor

Thanks for your response @alexvanboxel. Is there any active thread to track progress of ordering feature so I can start working on this once ordering is added? If the work has not been started yet, I could contribute there as well.

#32850

Copy link
Contributor

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants