-
Notifications
You must be signed in to change notification settings - Fork 2.7k
[pkg/stanza] update module go.uber.org/zap to v1.27.0 breaks tests #31442
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Labels
Comments
1 task
Pinging code owners for pkg/stanza: @djaglowski. See Adding Labels via Comments if you do not have permissions to add labels yourself. |
Pinging code owners:
See Adding Labels via Comments if you do not have permissions to add labels yourself. |
djaglowski
added a commit
that referenced
this issue
Feb 27, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [go.uber.org/zap](https://togithub.com/uber-go/zap) | `v1.26.0` -> `v1.27.0` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>uber-go/zap (go.uber.org/zap)</summary> ### [`v1.27.0`](https://togithub.com/uber-go/zap/releases/tag/v1.27.0) [Compare Source](https://togithub.com/uber-go/zap/compare/v1.26.0...v1.27.0) Enhancements: - [#​1378][]: Add `WithLazy` method for `SugaredLogger`. - [#​1399][]: zaptest: Add `NewTestingWriter` for customizing TestingWriter with more flexibility than `NewLogger`. - [#​1406][]: Add `Log`, `Logw`, `Logln` methods for `SugaredLogger`. - [#​1416][]: Add `WithPanicHook` option for testing panic logs. Thanks to [@​defval](https://togithub.com/defval), [@​dimmo](https://togithub.com/dimmo), [@​arxeiss](https://togithub.com/arxeiss), and [@​MKrupauskas](https://togithub.com/MKrupauskas) for their contributions to this release. [#​1378]: https://togithub.com/uber-go/zap/pull/1378 [#​1399]: https://togithub.com/uber-go/zap/pull/1399 [#​1406]: https://togithub.com/uber-go/zap/pull/1406 [#​1416]: https://togithub.com/uber-go/zap/pull/1416 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "on tuesday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/open-telemetry/opentelemetry-collector-contrib). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4yMTIuMCIsInVwZGF0ZWRJblZlciI6IjM3LjIxMi4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Closes #31442 --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: opentelemetrybot <[email protected]> Co-authored-by: Dan Jaglowski <[email protected]>
This was referenced Mar 5, 2024
XinRanZhAWS
pushed a commit
to XinRanZhAWS/opentelemetry-collector-contrib
that referenced
this issue
Mar 13, 2024
…1434) [](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [go.uber.org/zap](https://togithub.com/uber-go/zap) | `v1.26.0` -> `v1.27.0` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>uber-go/zap (go.uber.org/zap)</summary> ### [`v1.27.0`](https://togithub.com/uber-go/zap/releases/tag/v1.27.0) [Compare Source](https://togithub.com/uber-go/zap/compare/v1.26.0...v1.27.0) Enhancements: - [#&open-telemetry#8203;1378][]: Add `WithLazy` method for `SugaredLogger`. - [#&open-telemetry#8203;1399][]: zaptest: Add `NewTestingWriter` for customizing TestingWriter with more flexibility than `NewLogger`. - [#&open-telemetry#8203;1406][]: Add `Log`, `Logw`, `Logln` methods for `SugaredLogger`. - [#&open-telemetry#8203;1416][]: Add `WithPanicHook` option for testing panic logs. Thanks to [@&open-telemetry#8203;defval](https://togithub.com/defval), [@&open-telemetry#8203;dimmo](https://togithub.com/dimmo), [@&open-telemetry#8203;arxeiss](https://togithub.com/arxeiss), and [@&open-telemetry#8203;MKrupauskas](https://togithub.com/MKrupauskas) for their contributions to this release. [#&open-telemetry#8203;1378]: https://togithub.com/uber-go/zap/pull/1378 [#&open-telemetry#8203;1399]: https://togithub.com/uber-go/zap/pull/1399 [#&open-telemetry#8203;1406]: https://togithub.com/uber-go/zap/pull/1406 [#&open-telemetry#8203;1416]: https://togithub.com/uber-go/zap/pull/1416 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "on tuesday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/open-telemetry/opentelemetry-collector-contrib). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4yMTIuMCIsInVwZGF0ZWRJblZlciI6IjM3LjIxMi4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Closes open-telemetry#31442 --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: opentelemetrybot <[email protected]> Co-authored-by: Dan Jaglowski <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Component(s)
pkg/stanza
Describe the issue you're reporting
Related to #31434. pkg/stanza/errors/error_test.go breaks after the dependency update. See https://github.com/open-telemetry/opentelemetry-collector-contrib/actions/runs/8065563978/job/22031783400?pr=31434.
The text was updated successfully, but these errors were encountered: