-
-
Notifications
You must be signed in to change notification settings - Fork 127
Upd feat 120 #124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upd feat 120 #124
Conversation
… to avoid confusion between CLI tool and manual *docs: change wording in step 6 *docs: delete lines 149 to 156 *docs: delete step 9 and reword step 10 *docs: renumber steps from 9 to 11 *docs: add link to the pizza-verse repo as a good next step to practice contributing to open source.
✅ Deploy Preview for sauced-intro ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
**Manual Addition** | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Pondy007. This part needs to be omitted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok. Done : line "Manual Addition" removed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Pondy007. So far, your PR looks good. You just need to omit a section before I give another review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @Pondy007,
First of all, thank you for the PR and the prompt changes! Really appreciate it. ✨
Our intention in this issue is to remove the "Manual Addition" part as we will go for adding contributors with the CLI only.
So, from our side, we apologize that we missed to include an instruction to remove the subsection and clarify the wording adjustment accordingly that cause this kind of long review. 🙏
-
I've updated the issue to include removing the "Manual Addition" subsection. It's the one that I haven't checked.
-
After you done that, I've also left reviews here for you to fix.
Please let me know if you have questions or any help by tagging me here.
Thank you. 😊
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well done, @Pondy007! 🙌
Thank you for the changes! 😄
For your future reference, once you've fixed something from the suggestions, you can click the resolve button.
Doing this can help you and the maintainer to check which suggestion are done, and which are still need to be fixed.
This mostly happens because there's a Markdown extension or feature enabled in your VS Code, which is good. One trick that helps is when you need to indent a line for one tab, click tab 2 times, then save it. It will save the correct format of the indentation. But there are some cases where this trick won't work, for example when creating directory tree in Markdown. Hope this helps 😊 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well done @Pondy007! :) Thanks for contributing! :)
Description
This PR fixes the feature #120.
Solution implemented :
In the Getting Started subsection, I did the following:
Go to step 11 and renumber it step 10
Go to step 12 and renumber it step 11
To solve the second part of this issue, I made the following change to the last sentence of the exercise:
What type of PR is this? (check all applicable)
Related Tickets & Documents
Closes #120
Mobile & Desktop Screenshots/Recordings
Steps to QA
Added to documentation?
[optional] Are there any post-deployment tasks we need to perform?
[optional] What gif best describes this PR or how it makes you feel?
😊