Skip to content

Delete redundant text content #123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Delete redundant text content #123

wants to merge 1 commit into from

Conversation

Pondy007
Copy link
Contributor

Description

This PR fixes the bug #122

What type of PR is this? (check all applicable)

  • πŸ• Feature
  • πŸ› Bug Fix
  • πŸ“ Documentation Update
  • 🎨 Style
  • πŸ§‘β€πŸ’» Code Refactor
  • πŸ”₯ Performance Improvements
  • βœ… Test
  • πŸ€– Build
  • πŸ” CI
  • πŸ“¦ Chore (Release)
  • ⏩ Revert

Related Tickets & Documents

Fixes #122

Mobile & Desktop Screenshots/Recordings

image

Steps to QA

Please provide some steps for the reviewer to test your change. If you have wrote tests, you can mention that here instead.

  1. Click a link
  2. See there is no replicated text at the end

Added to documentation?

  • πŸ“œ README.md
  • πŸ““ docs.opensauced.pizza
  • πŸ• dev.to/opensauced
  • πŸ“• storybook
  • πŸ™… no documentation needed

[optional] Are there any post-deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

Proud of my first contribution. Hope I did not forget something.
image

Copy link

netlify bot commented Feb 22, 2024

βœ… Deploy Preview for sauced-intro ready!

Name Link
πŸ”¨ Latest commit df5fabf
πŸ” Latest deploy log https://app.netlify.com/sites/sauced-intro/deploys/65d75ba4047da50008e87c43
😎 Deploy Preview https://deploy-preview-123--sauced-intro.netlify.app
πŸ“± Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@CBID2 CBID2 closed this Feb 22, 2024
@CBID2
Copy link
Contributor

CBID2 commented Feb 22, 2024

Hi @Pondy007. I closed your Pull Request because it was not assigned to you yet. Please reread our contribution guidelines before submitting a pull request.

@CBID2 CBID2 reopened this Feb 22, 2024
@Pondy007
Copy link
Contributor Author

Hi @CBID2 ,
Thanks for the assignment ! You are right, one should be assigned before working on it. (My english is not as good as my french...)
Noted for next time ;-)

@CBID2 CBID2 added the documentation Improvements or additions to documentation label Feb 23, 2024
@Pondy007
Copy link
Contributor Author

Hi @CBID2 ,
What should I do now concerning this PR ?
As I am the author, I cannot approve change (which is normal).
Thank you.

Copy link
Contributor

@CBID2 CBID2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the wait @Pondy007. It looks good on my end. What do you think @adiati98?

@CBID2 CBID2 requested a review from adiati98 February 24, 2024 15:43
Copy link
Member

@adiati98 adiati98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well spot on!
Thank you, @Pondy007! πŸš€

Copy link
Member

@adiati98 adiati98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Pondy007 I just realized that you made this PR right on the main branch.
And we don't want to merge a PR that is worked on the main branch.

That said, I'm closing this PR.

The changes is already great.
You only need to create a new branch, make your changes there, then create a new PR.

Please let me know if you have any question.

Thank you!

@adiati98 adiati98 closed this Feb 26, 2024
@Pondy007
Copy link
Contributor Author

Hi @adiati98 ,
You are absolutely right ! I realized afterwards that I did my changes on main branch. (Beginner's mistake...)
I will do what you suggested.
Thx.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Text repeated twice on french translation
3 participants