Skip to content

by-name parameters do not get passed correctly #391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
shanejonas opened this issue Jul 26, 2020 · 1 comment · Fixed by #512
Closed

by-name parameters do not get passed correctly #391

shanejonas opened this issue Jul 26, 2020 · 1 comment · Fixed by #512
Labels
bug Something isn't working released

Comments

@shanejonas
Copy link
Member

shanejonas commented Jul 26, 2020 •
edited
Loading

image
image
image

Expected Behaviour

should give me just shanejonas not ["username", "shanejonas"] same with password, its giving me ["password", "foobar"] instead of just "foobar"
@shanejonas shanejonas added the bug Something isn't working label Jul 27, 2020
shanejonas added a commit that referenced this issue Dec 11, 2020
@shanejonas
fix: params by name sortParamKeys should return val not return ["key"…
b8d14e3 
…, val]

fixes #391
@shanejonas shanejonas mentioned this issue Dec 11, 2020
Merged
@openrpc-bastion
Copy link
Member

🎉 This issue has been resolved in version 1.8.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: params by name sortParamKeys should return val not return ["key", val] open-rpc/server-js
2 participants
@shanejonas @openrpc-bastion