Skip to content

Debug: Restore website deployment to GitHub Pages #995

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

NPDebs
Copy link
Collaborator

@NPDebs NPDebs commented Apr 30, 2025

This PR fixes #994 - thanks again for flagging, Yo!

In #948, a new GitHub Action was added, which primarily provides a live deploy preview link under each open Pull Request.
However, the previous Action that handled deployment to GitHub pages was removed in the process. This PR addresses the resulting effects of that...action. :-)

👍🎉 First of all, thanks for taking the time to contribute! 🎉👍

FOR CONTRIBUTOR

PR Type:

  • This PR adds a new blog post
  • This PR does something else (explain above)

FOR REVIEWERS

Thanks for taking the time to review! ❤️

Here are the list of things to make sure of:

  • The website builds (a check will fail if not)
  • All images have been added within the Pull Request and they have Alt text
  • If there are paragraphs or text, the key messages are highlighted
  • All internal links (within OLS website) use the {% link path_to_file.md %} format
  • The preview corresponds to the changes described in the Pull Request
  • The code is tidy and passes the linting tests

NPDebs added 2 commits April 30, 2025 15:13
This file was originally created for the deploy action, but its content was replaced by an action for PR preview. This commit resolves that.
This commit moves the PR Preview deployment action into a separate file -  i.e. deploy-preview.yml.
@NPDebs NPDebs marked this pull request as draft April 30, 2025 14:22
@NPDebs
Copy link
Collaborator Author

NPDebs commented Apr 30, 2025

Making these changes from a branch in my fork was not a very bright idea, because of the organisation-level access tokens (which I clearly do not have 😅) required to run these jobs.

@NPDebs
Copy link
Collaborator Author

NPDebs commented Apr 30, 2025

✍️ For the same reason, only PRs from branches created in the main website repo will generate a deploy preview. (see #996, #998)

Branches not created directly in the open-life-science.github.io repo (those created on forks) will not deploy or generate preview, for lack of access to environmental variables. (see #995, #997)

Compare #995 & #996; #997 & #998.

Action: Find a way to workaround permission issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Site appears not to be deploying any longer
1 participant