Skip to content

[ITEP-24904] fix manual deployment cluster drawer #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

RPG-coder-intc
Copy link
Contributor

@RPG-coder-intc RPG-coder-intc commented Apr 1, 2025

  • Original bug: Host name for multiple host is showing empty string. causing the table to break upon sorting on name
-{
-      Header: "Host Name",
-     accessor: "name",
-},
+{
+      Header: "Host Name",
+      apiName: "name",
+     accessor: (host) => host.name || host.resourceId,
+},

for completeness of this feature this pr will also add:

  • The ClusterDetails component seems to be in the wrong MFE folder. had to move it to the cluster-orch
  • Also filterByUuid was not present in the new host table

Video

https://intel.sharepoint.com/:v:/r/sites/lpuidevteam/Shared%20Documents/PRs/[deployment-create-manual-fix-demo.mp4](https://intel.sharepoint.com/:v:/r/sites/lpuidevteam/Shared%20Documents/PRs/deployment-create-manual-fix-demo.mp4?csf=1&web=1&e=4wPoja)?csf=1&web=1&e=4wPoja

https://intel.sharepoint.com/:v:/r/sites/lpuidevteam/Shared%20Documents/PRs/[deployment-manual-cluster-multiple-table-test-demo.mp4](https://intel.sharepoint.com/:v:/r/sites/lpuidevteam/Shared%20Documents/PRs/deployment-manual-cluster-multiple-table-test-demo.mp4?csf=1&web=1&e=kvjlAE)?csf=1&web=1&e=kvjlAE

@RPG-coder-intc RPG-coder-intc added the ready-for-review This PR has been validated on a running setup and is ready for review and merge label Apr 11, 2025
if (value === "resourceId" && state.hostIdsQuery !== undefined) {
return;
}
return `${value}="${action.payload}"`;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I had reviewed this before the repo was deleted. Allowing for props that result in empty filters that which have to be parsed later on seems like a potential source for future bugs. I think we need a better way to address this. We'll look at this post 3.0 release

@teone teone removed the ready-for-review This PR has been validated on a running setup and is ready for review and merge label Apr 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants