[ITEP-19820] Infra UI Maintainance List - Invalid Date Bug Safari #29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…thub.com/open-edge-platform/orch-ui into ITEP-19820_InvalidDateBugInSafariBrowser
…thub.com/open-edge-platform/orch-ui into ITEP-19820_InvalidDateBugInSafariBrowser
|
@teone, i may need a |
RPG-coder-intc
commented
Apr 7, 2025
Comment on lines
+8
to
+11
|
|
||
| .flex-item { | ||
| overflow: visible; | ||
| } |
There was a problem hiding this comment.
the dropdown for repeat date, repeat day, and repeat month selection is hidden due to the new <Flex /> component.
RPG-coder-intc
added
the
ready-for-review
teone
requested changes
Apr 7, 2025
teone
pushed a commit
that referenced
this pull request
Apr 8, 2025
RPG-coder-intc
removed
the
ready-for-review
RPG-coder-intc
commented
Apr 16, 2025
RPG-coder-intc
commented
Apr 16, 2025
RPG-coder-intc
commented
Apr 16, 2025
| @@ -184,7 +184,8 @@ export const getHumanReadableDuration = (durationSeconds: number) => { | |||
| /** Convert date-time in seconds format to `date, hh, mm` format */ | |||
| export const getDateTimeFromSeconds = (seconds: number) => { | |||
| const dateString = new Date(seconds * 1000).toUTCString().split(" "); | |||
| const date = [dateString[1], dateString[2], dateString[3]].join("/"); | |||
| // this will return date in `30-Jun-2023` format (which is supported in safari and chrome) | |||
| const date = [dateString[1], dateString[2], dateString[3]].join("-"); | |||
There was a problem hiding this comment.
note previously this was returning 30/Jun/2023 which was not supported in safari macOs
…thub.com/open-edge-platform/orch-ui into ITEP-19820_InvalidDateBugInSafariBrowser
teone
requested changes
Apr 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This bug is only reproducible in Safari (Mac OS) browser:
Reason:
Javascript Date() in safari doesnot recognize date substitution of format
30/Jun/2023. This value is converted from the Unix timestampgetDateTimeFromSecondsin single schedule maintenance.Fix:
Instead
30-Jun-2023is valid JS format in both safari and chrome.ref: https://stackoverflow.com/questions/4310953/invalid-date-in-safari
After fix
This is tested on chrome (windows)
Mac OS safari browser & chrome browser...