Skip to content

initial commit for ec2log #450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

initial commit for ec2log #450

wants to merge 6 commits into from

Conversation

paulfhncw
Copy link
Contributor

Description

Creates a new EC2Log

Fixes # (issue)

Any Newly Introduced Dependencies

None

How Has This Been Tested?

Mocked Unit Test only

Checklist:

  • I agree to use the APACHE-2.0 license for my code changes
  • I have not introduced any 3rd party dependency changes
  • I have performed a self-review of my code

@yi-tseng-intel yi-tseng-intel added this to the 3.1 milestone Jun 9, 2025
yi-tseng-intel and others added 3 commits June 9, 2025 23:37
@yi-tseng-intel
Merge branch 'main' into add-ec2log-step
09626f8
@yi-tseng-intel
Cleanup
044c05a 
- Remove "AWS" from step name
- Add missing upgrade statements
- Remove unused comments
@paulfhncw
added unit test for upgrade
a66ce6e
yi-tseng-intel
yi-tseng-intel reviewed Jun 10, 2025
View reviewed changes
new-installer/internal/steps/aws/ec2log.go
}

// Need to move Terraform state from old bucket to new bucket:
oldEC2LogBucketKey := fmt.Sprintf("%s/ec2log/%s", config.AWS.Region, config.Global.OrchName)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use cluster since the ec2log was under the cluster module and use the same key

Suggested change
oldEC2LogBucketKey := fmt.Sprintf("%s/ec2log/%s", config.AWS.Region, config.Global.OrchName)
oldEC2LogBucketKey := fmt.Sprintf("%s/cluster/%s", config.AWS.Region, config.Global.OrchName)

@paulfhncw
Create ec2log_test.go
7491c06 
code to unit ec2log. issue as eks needs to be created to attach a node group
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yi-tseng-intel yi-tseng-intel yi-tseng-intel left review comments

@charlesmcchan charlesmcchan Awaiting requested review from charlesmcchan charlesmcchan is a code owner

@ashridatta ashridatta Awaiting requested review from ashridatta ashridatta is a code owner

@se-chris-thach se-chris-thach Awaiting requested review from se-chris-thach se-chris-thach is a code owner

@Irakus Irakus Awaiting requested review from Irakus Irakus is a code owner

@ahalimx86 ahalimx86 Awaiting requested review from ahalimx86 ahalimx86 is a code owner

@garyloug garyloug Awaiting requested review from garyloug garyloug is a code owner

@palade palade Awaiting requested review from palade palade is a code owner

@johnoloughlin johnoloughlin Awaiting requested review from johnoloughlin johnoloughlin is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
installer WIP
Projects
None yet
Milestone
3.1
Development

Successfully merging this pull request may close these issues.
2 participants
@paulfhncw @yi-tseng-intel