Skip to content

Support PointCloud dataset by DatumaroBinary format #830

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

vinnamkim
Copy link
Contributor

@vinnamkim vinnamkim commented Feb 27, 2023

Summary

  • Ticket no. 104650
  • Finish to support PointCloud dataset by DatumaroBinary format for compatibility with Datumaro format.

How to test

Checklist

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below)
# Copyright (C) 2023 Intel Corporation
#
# SPDX-License-Identifier: MIT

Signed-off-by: Kim, Vinnam <[email protected]>
Signed-off-by: Kim, Vinnam <[email protected]>
Signed-off-by: Kim, Vinnam <[email protected]>
 - Refactor CommonSemanticSegmentation unit tests as well

Signed-off-by: Kim, Vinnam <[email protected]>
 - Support DatasetItem by Datumaro binary format but annotations are not yet.

Signed-off-by: Kim, Vinnam <[email protected]>
@vinnamkim vinnamkim added ENHANCE Enhancement of existing features data formats PR is related to dataset formats labels Feb 27, 2023
@vinnamkim vinnamkim added this to the 1.1.0 milestone Feb 27, 2023
@vinnamkim vinnamkim force-pushed the feature/support-point-cloud-by-datumaro-binary-format branch from 5020e84 to 8a5d182 Compare February 27, 2023 10:44
@vinnamkim vinnamkim force-pushed the feature/support-point-cloud-by-datumaro-binary-format branch from 8a5d182 to 0a17f08 Compare February 28, 2023 05:38
…point-cloud-by-datumaro-binary-format

Signed-off-by: Kim, Vinnam <[email protected]>
Signed-off-by: Kim, Vinnam <[email protected]>
@vinnamkim vinnamkim marked this pull request as ready for review March 7, 2023 07:02
@codecov-commenter
Copy link

codecov-commenter commented Mar 7, 2023

Codecov Report

Patch coverage: 88.75% and project coverage change: +0.05 🎉

Comparison is base (6b613c7) 78.48% compared to head (973935a) 78.54%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #830      +/-   ##
===========================================
+ Coverage    78.48%   78.54%   +0.05%     
===========================================
  Files          196      197       +1     
  Lines        24304    24367      +63     
  Branches      4946     4950       +4     
===========================================
+ Hits         19075    19138      +63     
  Misses        4127     4127              
  Partials      1102     1102              
Flag Coverage Δ
macos-11_Python-3.8 77.87% <88.75%> (+0.05%) ⬆️
ubuntu-20.04_Python-3.8 78.52% <88.75%> (+0.05%) ⬆️
windows-2019_Python-3.8 78.47% <88.75%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
datumaro/plugins/data_formats/datumaro/base.py 93.07% <ø> (ø)
...aro/plugins/data_formats/datumaro_binary/mapper.py 0.00% <0.00%> (ø)
...umaro/plugins/data_formats/datumaro_binary/base.py 91.93% <81.25%> (-4.22%) ⬇️
...ugins/data_formats/datumaro_binary/mapper/media.py 88.23% <88.23%> (ø)
datumaro/plugins/data_formats/datumaro/exporter.py 95.61% <97.56%> (+1.16%) ⬆️
datumaro/components/media.py 83.56% <100.00%> (+0.13%) ⬆️
...o/plugins/data_formats/datumaro_binary/exporter.py 96.96% <100.00%> (-0.50%) ⬇️
...ns/data_formats/datumaro_binary/mapper/__init__.py 100.00% <100.00%> (ø)
...ata_formats/datumaro_binary/mapper/dataset_item.py 100.00% <100.00%> (+18.96%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

 - And ImageMapper and PointCloudMapper inherit MediaElementMapper to
use the common function backward_dict()

Signed-off-by: Kim, Vinnam <[email protected]>
bonhunko
bonhunko previously approved these changes Mar 8, 2023
Copy link
Contributor

@bonhunko bonhunko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!
I left one minor comment.

@vinnamkim vinnamkim merged commit d5487c7 into open-edge-platform:develop Mar 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data formats PR is related to dataset formats ENHANCE Enhancement of existing features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants