-
Notifications
You must be signed in to change notification settings - Fork 141
Support MVTec anomaly data and add UnionMerge #810
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportBase: 77.60% // Head: 77.72% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## develop #810 +/- ##
===========================================
+ Coverage 77.60% 77.72% +0.12%
===========================================
Files 179 184 +5
Lines 23238 23570 +332
Branches 5023 5082 +59
===========================================
+ Hits 18034 18320 +286
- Misses 4141 4169 +28
- Partials 1063 1081 +18
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
datumaro/components/operations.py
Outdated
Merges several datasets using the "simple" algorithm: | ||
- items are matched by (id, subset) pairs | ||
- matching items share the media info available: | ||
|
||
- nothing + nothing = nothing | ||
- nothing + something = something | ||
- something A + something B = conflict | ||
- annotations are matched by value and shared | ||
- in case of conflicts, throws an error |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Descriptions are not updated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I simply updated the description. Do we need to add more comments here?
For instance, "when categories information between subsets, e.g., train and validation, are different, we need to set the merging policy as union. Please refer to the MVTec anomaly dataset."
If so, how about IntersectMerge case?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know much about it except IntersectMerge
do more than this to merge annotations. So let's leave it as it is for now. It would be good to enhance those descriptions afterwards. I think that it can be done with a future work we found for refactoring merger codes to resolve their circular dependency problems.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
agree, let me prepare the next PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Summary
How to test
Checklist
develop
branchLicense
Feel free to contact the maintainers if that's a concern.