Skip to content

Wrap title text according to plot width #769

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 28, 2022

Conversation

vinnamkim
Copy link
Contributor

@vinnamkim vinnamkim commented Nov 23, 2022

Signed-off-by: Kim, Vinnam [email protected]

Summary

This PR introduces title text wrapping according to plot width in Visualizer.
image

How to test

Checklist

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below)
# Copyright (C) 2021 Intel Corporation
#
# SPDX-License-Identifier: MIT

@codecov-commenter
Copy link

codecov-commenter commented Nov 23, 2022

Codecov Report

Base: 84.20% // Head: 84.20% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (9414bfd) compared to base (eabce02).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #769   +/-   ##
========================================
  Coverage    84.20%   84.20%           
========================================
  Files          157      157           
  Lines        21931    21939    +8     
  Branches      4806     4807    +1     
========================================
+ Hits         18467    18474    +7     
  Misses        2369     2369           
- Partials      1095     1096    +1     
Flag Coverage Δ
macos-10.15_Python-3.10 84.11% <100.00%> (+<0.01%) ⬆️
macos-10.15_Python-3.7 83.80% <100.00%> (+<0.01%) ⬆️
macos-10.15_Python-3.8 84.04% <100.00%> (+<0.01%) ⬆️
macos-10.15_Python-3.9 84.05% <100.00%> (+<0.01%) ⬆️
ubuntu-20.04_Python-3.10 84.13% <100.00%> (+<0.01%) ⬆️
ubuntu-20.04_Python-3.7 83.82% <100.00%> (+0.02%) ⬆️
ubuntu-20.04_Python-3.8 84.04% <100.00%> (+<0.01%) ⬆️
ubuntu-20.04_Python-3.9 84.05% <100.00%> (-0.02%) ⬇️
windows-2019_Python-3.10 84.13% <100.00%> (+<0.01%) ⬆️
windows-2019_Python-3.7 83.82% <100.00%> (+<0.01%) ⬆️
windows-2019_Python-3.8 84.05% <100.00%> (+<0.01%) ⬆️
windows-2019_Python-3.9 84.06% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
datumaro/components/visualizer.py 93.17% <100.00%> (+0.27%) ⬆️
datumaro/plugins/splitter.py 88.44% <0.00%> (-0.23%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@vinnamkim vinnamkim added ready-to-review ENHANCE Enhancement of existing features labels Nov 23, 2022
bonhunko
bonhunko previously approved these changes Nov 24, 2022
Copy link
Contributor

@bonhunko bonhunko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@sooahleex sooahleex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@wonjuleee wonjuleee merged commit b9db543 into open-edge-platform:develop Nov 28, 2022
wonjuleee pushed a commit to wonjuleee/datumaro that referenced this pull request Nov 30, 2022
* Wrap title text according to plot width

Signed-off-by: Kim, Vinnam <[email protected]>

* Update CHANGELOG.md

Signed-off-by: Kim, Vinnam <[email protected]>

Signed-off-by: Kim, Vinnam <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ENHANCE Enhancement of existing features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants