ByteImage: try to guess the image extension if one is not given #595
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This lets us avoid needless re-encoding when a `ByteImage` is saved as the format it already is in. Unfortunately, neither OpenCV nor PIL seem to offer functionality to detect the format without loading the image, so we have to implement it ourselves. I only added support for a handful of most common formats, which should cover a majority of cases.
zhiltsov-max
approved these changes
Dec 22, 2021
It's useful for TFDS integration, because TFDS does not provide file names for datasets that didn't originally have them (e.g., MNIST). |
|
Shouldn't tfrecords contain the format field? https://github.com/openvinotoolkit/datumaro/blob/develop/datumaro/plugins/tf_detection_api_format/extractor.py#L79 |
|
TFRecords can contain basically anything. In the case of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This lets us avoid needless re-encoding when a
ByteImageis saved as the format it already is in.Unfortunately, neither OpenCV nor PIL seem to offer functionality to detect the format without loading the image, so we have to implement it ourselves. I only added support for a handful of most common formats, which should cover a majority of cases.
How to test
Checklist
developbranchLicense
Feel free to contact the maintainers if that's a concern.