Skip to content

Mergeback 1.8.0 to develop #1566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Jul 12, 2024
Merged

Conversation

yunchu
Copy link
Contributor

@yunchu yunchu commented Jul 12, 2024

Summary

How to test

Checklist

  • I have added unit tests to cover my changes.​
  • I have added integration tests to cover my changes.​
  • I have added the description of my changes into CHANGELOG.​
  • I have updated the documentation accordingly

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below).
# Copyright (C) 2024 Intel Corporation
#
# SPDX-License-Identifier: MIT

sooahleex and others added 10 commits June 25, 2024 13:33
…ion type (open-edge-platform#1533)

- Fix to update annotation for `Tabular` and `Caption` annotation type during `Clean` transform
- Add comment for `Clean`
- Fix typo of function name
- Update unit test
### Summary
Resolves 145146 and 145169 for datumaro format.
* 145146
- When exporting a video several times, it should be saved only once to
prevent the video from being overwritten.
* 145169
- Exported video paths should be relative from `videos/<subset>`
directory.

### How to test
Test for 145169 is automatically done by `test_can_save_and_load` @
tests/unit/data_formats/datumaro/test_datumaro_format.py


### Checklist
<!-- Put an 'x' in all the boxes that apply -->
- [x] I have added unit tests to cover my changes.​
- [ ] I have added integration tests to cover my changes.​
- [x] I have added the description of my changes into
[CHANGELOG](https://github.com/openvinotoolkit/datumaro/blob/develop/CHANGELOG.md).​
- [ ] I have updated the
[documentation](https://github.com/openvinotoolkit/datumaro/tree/develop/docs)
accordingly

### License

- [x] I submit _my code changes_ under the same [MIT
License](https://github.com/openvinotoolkit/datumaro/blob/develop/LICENSE)
that covers the project.
  Feel free to contact the maintainers if that's a concern.
- [ ] I have updated the license header for each file (see an example
below).

```python
# Copyright (C) 2024 Intel Corporation
#
# SPDX-License-Identifier: MIT
```
…1534)

- Add notebook to show how to clean dataset from kaggle through Datumaro
…m#1562)

Duplicate of open-edge-platform#1528 but with `releases/1.8.0` base.

---------

Signed-off-by: Ilya Trushkin <[email protected]>
@yunchu yunchu requested review from a team as code owners July 12, 2024 03:54
@yunchu yunchu requested review from sooahleex and removed request for a team July 12, 2024 03:54
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link

codecov bot commented Jul 12, 2024

Codecov Report

Attention: Patch coverage is 84.37500% with 5 lines in your changes missing coverage. Please review.

Project coverage is 81.03%. Comparing base (63da2ff) to head (9bdf8de).
Report is 13 commits behind head on develop.

Files Patch % Lines
src/datumaro/components/dataset.py 25.00% 2 Missing and 1 partial ⚠️
src/datumaro/plugins/transforms.py 88.88% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1566      +/-   ##
===========================================
- Coverage    81.05%   81.03%   -0.03%     
===========================================
  Files          276      276              
  Lines        32359    32430      +71     
  Branches      6575     6595      +20     
===========================================
+ Hits         26230    26280      +50     
- Misses        4684     4696      +12     
- Partials      1445     1454       +9     
Flag Coverage Δ
ubuntu-20.04_Python-3.10 81.02% <84.37%> (-0.03%) ⬇️
windows-2022_Python-3.10 81.01% <84.37%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yunchu yunchu merged commit 3eace34 into open-edge-platform:develop Jul 12, 2024
8 checks passed
@yunchu yunchu deleted the mergeback/1.8.0 branch July 12, 2024 05:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants