Skip to content

Mark xfails on flaky and unavailable tests #1141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 5, 2023

Conversation

vinnamkim
Copy link
Contributor

Summary

  • Same as title

How to test

Checklist

  • I have added unit tests to cover my changes.​
  • I have added integration tests to cover my changes.​
  • I have added the description of my changes into CHANGELOG.​
  • I have updated the documentation accordingly

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below).
# Copyright (C) 2023 Intel Corporation
#
# SPDX-License-Identifier: MIT

@vinnamkim vinnamkim changed the title Mark xfails for flaky and unavailable tests Mark xfails to flaky and unavailable tests Sep 5, 2023
@vinnamkim vinnamkim added this to the 1.5.0 milestone Sep 5, 2023
@vinnamkim vinnamkim added the BUG Something isn't working label Sep 5, 2023
@vinnamkim vinnamkim marked this pull request as ready for review September 5, 2023 06:23
@vinnamkim vinnamkim requested review from a team as code owners September 5, 2023 06:23
@vinnamkim vinnamkim requested review from sooahleex and removed request for a team September 5, 2023 06:23
Copy link
Contributor

@sooahleex sooahleex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@vinnamkim vinnamkim changed the title Mark xfails to flaky and unavailable tests Mark xfails on flaky and unavailable tests Sep 5, 2023
@codecov
Copy link

codecov bot commented Sep 5, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.50% ⚠️

Comparison is base (01b4f35) 80.16% compared to head (521a102) 79.67%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1141      +/-   ##
===========================================
- Coverage    80.16%   79.67%   -0.50%     
===========================================
  Files          260      260              
  Lines        29370    29370              
  Branches      5757     5757              
===========================================
- Hits         23545    23401     -144     
- Misses        4484     4634     +150     
+ Partials      1341     1335       -6     
Flag Coverage Δ
macos-11_Python-3.8 78.73% <ø> (-0.54%) ⬇️
ubuntu-20.04_Python-3.8 79.66% <ø> (-0.49%) ⬇️
windows-2019_Python-3.8 79.55% <ø> (-0.53%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vinnamkim vinnamkim merged commit 0293de1 into open-edge-platform:develop Sep 5, 2023
@vinnamkim vinnamkim deleted the hotfix/mark-xfails branch September 5, 2023 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BUG Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants