-
Notifications
You must be signed in to change notification settings - Fork 742
Add support for MLFlow logger #1847
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for MLFlow logger #1847
Conversation
Check out this pull request onΒ See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
I saw that DCO failed. I'm not sure if any of the solutions under "Details" are applicable. Could someone kindly provide some guidance or recommendations on how to address this issue? |
Hi @DoMaLi94, it's passing now. Thanks for creating this PR. The team will review it, and get back to you |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for creating this PR! I have a single comment concerning the import error.
Signed-off-by: Dominik Linsmayer <[email protected]>
Signed-off-by: Dominik Linsmayer <[email protected]>
Signed-off-by: Dominik Linsmayer <[email protected]>
After my new commits DCO fails again. Is it safe to follow the instructions under Details and perform a rebase in this state? My newer commits now include a Signed-off-by line :). |
it's alright, I've now set DCO to pass and triggered the CI. |
β¦.0.0 to match the requirements from lightning in requirements/core.txt Signed-off-by: Dominik Linsmayer <[email protected]>
Signed-off-by: Dominik Linsmayer <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for your contribution!
The tests are failing due to 601_mlflow_logging.ipynb. We will need to have a look at it |
The test fails due to the "magic command" |
Hey, J'ai créé une intégration mlflow pour yolov9 Mais l'intégration mlflow n'a pas besoin d'etre à proprement parlé un Je vous laisse jeter un oeil pour vous en inspirer, si cela vous permet de reussir à construire le logger pour Anomalib Cheers ! |
Signed-off-by: Dominik Linsmayer <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution!
π Description
This PR integrates MLFlow into Anomalib.
Addresses #1206
β¨ Changes
Select what type of change your PR is:
β Checklist
Before you submit your pull request, please make sure you have completed the following steps:
For more information about code review checklists, see the Code Review Checklist.