This repository was archived by the owner on Mar 3, 2025. It is now read-only.
feat: allow to disable and configure meilisearch host #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ian2012
force-pushed
the
cag/improvements
branch
from
b052d7b to
0ec268c
Compare
Ian2012
force-pushed
the
cag/improvements
branch
from
0ec268c to
6b98e6f
Compare
|
@Ian2012 Thanks! But for Sumac and future versions, this plugin won't be used as Tutor now has built-in Meilisearch support: overhangio/tutor#1141 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds two new settings to control whether to run meilisearch and which is the host (in case the meilisearch installation is external)
Automatically tested on: openedx/openedx-k8s-harmony#111