Skip to content

🌱 chore: e2e hosted and singleton should not be run on DOC-ONLY changes #855

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

mikeshng
Copy link
Member

Summary

e2e hosted and singleton GitHub workflow should not be run on DOC-ONLY changes

Related issue(s)

Fixes NA

@openshift-ci openshift-ci bot requested review from deads2k and jnpacker February 27, 2025 00:55
@mikeshng
Copy link
Member Author

/assign @qiujian16

Copy link

codecov bot commented Feb 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.68%. Comparing base (1daf3fe) to head (7d88044).
Report is 12 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #855   +/-   ##
=======================================
  Coverage   63.68%   63.68%           
=======================================
  Files         193      193           
  Lines       18839    18839           
=======================================
  Hits        11998    11998           
  Misses       5861     5861           
  Partials      980      980           
Flag Coverage Δ
unit 63.68% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mikeshng
Copy link
Member Author

mikeshng commented Mar 6, 2025

@qiujian16 could you PTAL and this PR so doc fixes won't run the two unnecessary e2e (hosted, singleton) github actions? Thanks.

@qiujian16
Copy link
Member

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm label Mar 7, 2025
Copy link
Contributor

openshift-ci bot commented Mar 7, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mikeshng, qiujian16

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Mar 7, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit 8b11697 into open-cluster-management-io:main Mar 7, 2025
15 checks passed
@mikeshng mikeshng deleted the fix-doc-only-workflow branch March 7, 2025 01:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants