Skip to content

🌱 refactor to use common HasFinalizer func #830

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

zhiweiyin318
Copy link
Member

Summary

Related issue(s)

Fixes #

@openshift-ci openshift-ci bot requested review from elgnay and haowells February 13, 2025 01:23
Copy link

codecov bot commented Feb 13, 2025

Codecov Report

Attention: Patch coverage is 75.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 63.85%. Comparing base (e1f83d7) to head (9a727c2).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...lers/klusterletcontroller/klusterlet_controller.go 50.00% 0 Missing and 1 partial ⚠️
...usterletcontroller/klusterlet_managed_reconcile.go 0.00% 0 Missing and 1 partial ⚠️
...lers/manifestcontroller/manifestwork_controller.go 0.00% 0 Missing and 1 partial ⚠️
...ers/statuscontroller/availablestatus_controller.go 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #830      +/-   ##
==========================================
+ Coverage   63.82%   63.85%   +0.02%     
==========================================
  Files         193      193              
  Lines       18667    18663       -4     
==========================================
+ Hits        11914    11917       +3     
+ Misses       5772     5766       -6     
+ Partials      981      980       -1     
Flag Coverage Δ
unit 63.85% <75.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@qiujian16 qiujian16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

Copy link
Contributor

openshift-ci bot commented Feb 13, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiujian16, zhiweiyin318

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 568789f into open-cluster-management-io:main Feb 13, 2025
15 checks passed
@zhiweiyin318 zhiweiyin318 deleted the check-finalizer branch February 13, 2025 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants