Skip to content

🌱 Requeue importer when secret is not found #808

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

qiujian16
Copy link
Member

Summary

requeue when the kubeconfig secret is not found. We cannot ensure that we always can get secret when capi cluster is in provisioned state.

Related issue(s)

Fixes #

Copy link
Contributor

openshift-ci bot commented Jan 17, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiujian16

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

codecov bot commented Jan 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.85%. Comparing base (34275ef) to head (e60d5fd).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #808      +/-   ##
==========================================
+ Coverage   63.76%   63.85%   +0.09%     
==========================================
  Files         192      192              
  Lines       18659    18661       +2     
==========================================
+ Hits        11897    11916      +19     
+ Misses       5781     5766      -15     
+ Partials      981      979       -2     
Flag Coverage Δ
unit 63.85% <100.00%> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zhiweiyin318
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Jan 17, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit 54a99fe into open-cluster-management-io:main Jan 17, 2025
15 checks passed
@qiujian16 qiujian16 deleted the requeue-importer branch January 17, 2025 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants