✨ Add a configmap to handle the proxy ca bundle #772
Conversation
zhujian7
force-pushed
the
proxy-ca-bundle
branch
from
4ff7aa9 to
db2ce62
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #772 +/- ##
==========================================
+ Coverage 63.60% 63.74% +0.13%
==========================================
Files 192 192
Lines 18433 18563 +130
==========================================
+ Hits 11725 11833 +108
- Misses 5735 5750 +15
- Partials 973 980 +7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
zhujian7
force-pushed
the
proxy-ca-bundle
branch
from
db2ce62 to
8464296
Compare
zhujian7
changed the title
zhujian7
force-pushed
the
proxy-ca-bundle
branch
from
8464296 to
524aa5f
Compare
|
/cc @qiujian16 @elgnay |
| @@ -331,27 +334,34 @@ func (d *imageDecorator) decorate(pod *corev1.PodTemplateSpec) error { | |||
| return nil | |||
| } | |||
|
|
|||
| type proxyDecorator struct { | |||
| type objectsInjector interface { | |||
There was a problem hiding this comment.
some comments on each interface.
pkg/addon/templateagent/decorator.go
Outdated
|
|
||
| pc, ok := proxyConfig.(addonapiv1alpha1.ProxyConfig) | ||
| if !ok { | ||
| klog.InfoS("proxy config value is invalid", "value", proxyConfig) |
There was a problem hiding this comment.
should this be a warning? also it is better to use the contextual logger.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: qiujian16, zhujian7 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
zhujian7
force-pushed
the
proxy-ca-bundle
branch
2 times, most recently
from
380504b to
12c3a40
Compare
Signed-off-by: zhujian <[email protected]>
zhujian7
force-pushed
the
proxy-ca-bundle
branch
from
12c3a40 to
fd1b17d
Compare
Signed-off-by: zhujian <[email protected]>
|
/lgtm |
openshift-merge-bot
bot
merged commit 3f9b886
into
open-cluster-management-io:main
Summary
This is a follow-up of PR #760, in this PR, it will handle the ca bundle for proxy config, a configmap containing the ca bundle will be created and mounted to the agent deployments/daemonsets. and the mounted ca bundle file path will be injected as the environment
CA_BUNDLE_FILE_PATHto the deployments/daemonsets. Addon developers can use the environment to get the ca bundle data.Related issue(s)
#761
Fixes #