🐛 Fix duplicate deployment names in klusterlet-agent availability message

[RokibulHasan7]

Summary

Related issue(s)

Fixes #

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.05%. Comparing base (865ae06) to head (980cd44).
Report is 2 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #671      +/-   ##
==========================================
+ Coverage   63.04%   63.05%   +0.01%     
==========================================
  Files         182      182              
  Lines       17606    17612       +6     
==========================================
+ Hits        11100    11106       +6     
  Misses       5594     5594              
  Partials      912      912              

Flag	Coverage Δ
unit	63.05% <100.00%> (+0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[zhujian7]

Another option is to deduplicate the agents in the checkAgentsDeploymentAvailable func, like:

// Check agent deployments, if both of them have at least 1 available replicas, return available condition
func checkAgentsDeploymentAvailable(ctx context.Context, kubeClient kubernetes.Interface, agents []klusterletAgent) metav1.Condition {
	var availableMessages []string
	components := sets.Set[string]{}  ### import "k8s.io/apimachinery/pkg/util/sets"
	for _, agent := range agents {
		componentID := fmt.Sprintf("%s-%s", agent.namespace, agent.deploymentName)
		if components.Has(componentID) {
			continue
		}
		components.Insert(componentID)
		deployment, err := kubeClient.AppsV1().Deployments(agent.namespace).Get(ctx, agent.deploymentName, metav1.GetOptions{})
		...
}

[zhujian7]

/lgtm

[xuezhaojun]

@RokibulHasan7 Can we have a comparison of how the message looks before and after the change. This will help followers and code readers understand the fix better. Thank you!

[RokibulHasan7]

@RokibulHasan7 Can we have a comparison of how the message looks before and after the change. This will help followers and code readers understand the fix better. Thank you!

Before:

  Type:			Available
  Status:		True
  LastTransitionTime:	2024-10-27 13:25:38 +0600 +06
  Reason:		KlusterletAvailable
  Message:		deployments are ready: klusterlet-agent,klusterlet-agent

After:

  Type:			Available
  Status:		True
  LastTransitionTime:	2024-10-27 13:25:38 +0600 +06
  Reason:		KlusterletAvailable
  Message:		deployments are ready: klusterlet-agent

[zhujian7]

/cc @qiujian16

[qiujian16]

good catch, thanks!
/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiujian16, RokibulHasan7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• pkg/operator/OWNERS [qiujian16]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment