Skip to content

🐛 Use context cancel func to trigger reselect #658

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

qiujian16
Copy link
Member

Summary

Related issue(s)

Fixes #

@openshift-ci openshift-ci bot requested review from skeeey and xuezhaojun October 18, 2024 06:59
Copy link
Contributor

openshift-ci bot commented Oct 18, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiujian16

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@qiujian16
Copy link
Member Author

/assign @xuezhaojun
/hold

Copy link

codecov bot commented Oct 18, 2024

Codecov Report

Attention: Patch coverage is 64.70588% with 6 lines in your changes missing coverage. Please review.

Project coverage is 63.70%. Comparing base (26f9e74) to head (86bf7f0).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
pkg/registration/spoke/spokeagent.go 64.70% 5 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #658      +/-   ##
==========================================
+ Coverage   63.04%   63.70%   +0.65%     
==========================================
  Files         182      182              
  Lines       17622    17603      -19     
==========================================
+ Hits        11110    11214     +104     
+ Misses       5600     5460     -140     
- Partials      912      929      +17     
Flag Coverage Δ
unit 63.70% <64.70%> (+0.65%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@qiujian16
Copy link
Member Author

/unhold

@xuezhaojun
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Oct 29, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit fa98535 into open-cluster-management-io:main Oct 29, 2024
15 checks passed
@mikeshng mikeshng mentioned this pull request Nov 1, 2024
@qiujian16 qiujian16 deleted the use-cancel branch March 27, 2025 03:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants