Skip to content

🌱 support set imagepullsecret credential in helm chart and run e2e using helm chart #605

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

zhiweiyin318
Copy link
Member

@zhiweiyin318 zhiweiyin318 commented Aug 29, 2024

Summary

  1. support set imagepullsecret credential in the helm chart.
  2. set the token-secret length to 16 in the chart.
  3. use helm chart to deploy in e2e.
  4. add a flag to control if create operator CR, because do not need create klusterlet CR in e2e deploy stage. the default is to create.
  5. move the chart config struct to the helper dir. the consumer will only import the helper dir.

Related issue(s)

Fixes #

@openshift-ci openshift-ci bot requested review from elgnay and xuezhaojun August 29, 2024 09:42
Copy link

codecov bot commented Aug 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.85%. Comparing base (567a9a4) to head (a272209).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #605   +/-   ##
=======================================
  Coverage   63.84%   63.85%           
=======================================
  Files         180      180           
  Lines       14094    14100    +6     
=======================================
+ Hits         8999     9003    +4     
- Misses       4193     4194    +1     
- Partials      902      903    +1     
Flag Coverage Δ
unit 63.85% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zhiweiyin318
Copy link
Member Author

/assign @qiujian16

Copy link
Member

@qiujian16 qiujian16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm label Aug 29, 2024
Copy link
Contributor

openshift-ci bot commented Aug 29, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiujian16, zhiweiyin318

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 7946f87 into open-cluster-management-io:main Aug 29, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants