-
Notifications
You must be signed in to change notification settings - Fork 107
✨Operator support MultipleHubs. #524
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨Operator support MultipleHubs. #524
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #524 +/- ##
==========================================
- Coverage 62.44% 62.40% -0.05%
==========================================
Files 138 138
Lines 11610 11605 -5
==========================================
- Hits 7250 7242 -8
- Misses 3593 3597 +4
+ Partials 767 766 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
25658c2
to
050ace2
Compare
a79bafb
to
b7a249c
Compare
/assign @qiujian16 |
b7a249c
to
2526772
Compare
/assign @elgnay |
pkg/operator/operators/klusterlet/controllers/klusterletcontroller/klusterlet_controller.go
Outdated
Show resolved
Hide resolved
pkg/operator/operators/klusterlet/controllers/klusterletcontroller/klusterlet_controller.go
Outdated
Show resolved
Hide resolved
pkg/operator/operators/klusterlet/controllers/ssarcontroller/klusterlet_ssar_controller.go
Show resolved
Hide resolved
// TODO: @xuezhaojun after the agent switch to the hub2, the 'managedcluster' on the hub1 keep showing `Available` status | ||
// This is because: | ||
// * the lease contoller only watch managedcluster resource, no periodical check on the managedcluster lease | ||
// * if the `hubAcceptsClient` is false, the controller will skip the reconciliation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this looks like a bug cc @elgnay
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- the lease contoller only watch managedcluster resource
The lease contoller watches both the managedcluster and the lease;
- the lease contoller only watch managedcluster resource, no periodical check on the managedcluster lease
The the managed cluster will be requeued after LeaseDurationSeconds.
- if the
hubAcceptsClient
is false, the controller will skip the reconciliation
That's true. The current logic of the controller does not handle hubAcceptsClient==false
very well. Some other controllers may have the similar issue.
ab0c3e3
to
65874b1
Compare
@qiujian16 The e2e part is removed and will join the refactor PR, the intergration test added, please take another look, thanks! |
929feaf
to
5d8b3d9
Compare
5b21bb6
to
ee00f8d
Compare
4502439
to
5e68514
Compare
Signed-off-by: xuezhaojun <[email protected]>
5e68514
to
7b61bec
Compare
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: qiujian16, xuezhaojun The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
5a747e8
into
open-cluster-management-io:main
Summary
The PR is to support MultiHubs also in the operator.
The PR is related to: #443
Some conversations that need highlight: