🌱 Refactor client certificate

[xuezhaojun]

Summary

• Remove the function HasValidHubKubeconfig since it's not used anymore.
• Print more information in shouldCreateCSR function.

[codecov]

Codecov Report

Attention: Patch coverage is 78.57143% with 6 lines in your changes missing coverage. Please review.

Project coverage is 62.41%. Comparing base (a14450a) to head (3439fd4).

Files	Patch %	Lines
pkg/registration/clientcert/cert_controller.go	78.57%	5 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #522      +/-   ##
==========================================
- Coverage   62.44%   62.41%   -0.04%     
==========================================
  Files         138      138              
  Lines       11610    11590      -20     
==========================================
- Hits         7250     7234      -16     
+ Misses       3593     3591       -2     
+ Partials      767      765       -2     

Flag	Coverage Δ
unit	62.41% <78.57%> (-0.04%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[xuezhaojun]

/assign @qiujian16

[xuezhaojun]

/hold

[xuezhaojun]

/unhold

[xuezhaojun]

/assign @elgnay

Please take a review when you have time, thanks!

[qiujian16]

/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiujian16, xuezhaojun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• pkg/registration/OWNERS [qiujian16]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[qiujian16]

/hold
@elgnay this may conflict with the PR that remove additionalDataSensitive flag?

[qiujian16]

/lgtm

[xuezhaojun]

@qiujian16 code rebased, please take another review.

[xuezhaojun]

/unhold

[qiujian16]

/lgtm