✨ Add a disable-default-addon-namespace flag

[qiujian16]

if the flag is set, default addon ns will not be created by the operator.

Summary

Related issue(s)

Fixes #474

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiujian16

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [qiujian16]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[codecov]

Codecov Report

Attention: Patch coverage is 69.23077% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 62.74%. Comparing base (c61895c) to head (8d6ef2a).
Report is 4 commits behind head on main.

Files	Patch %	Lines
...usterletcontroller/klusterlet_managed_reconcile.go	70.58%	2 Missing and 3 partials ⚠️
...lers/klusterletcontroller/klusterlet_controller.go	33.33%	2 Missing ⚠️
...sterletcontroller/klusterlet_cleanup_controller.go	50.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #484      +/-   ##
==========================================
+ Coverage   62.71%   62.74%   +0.03%     
==========================================
  Files         136      136              
  Lines       11580    11593      +13     
==========================================
+ Hits         7262     7274      +12     
- Misses       3550     3551       +1     
  Partials      768      768              

Flag	Coverage Δ
unit	62.74% <69.23%> (+0.03%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[clyang82]

what is behaviour if the disable-default-addon-namespace is set as false at the beginning, then update to true?

[elgnay]

Should this line be updated as well to remove the the default add-on ns? https://github.com/qiujian16/ocm/blob/disable-addon-ns/pkg/operator/operators/klusterlet/controllers/klusterletcontroller/klusterlet_namespace_reconcile.go#L42

[qiujian16]

what is behaviour if the disable-default-addon-namespace is set as false at the beginning, then update to true?

the namespace will be leftover, it actually is safer.

[qiujian16]

Should this line be updated as well to remove the the default add-on ns? https://github.com/qiujian16/ocm/blob/disable-addon-ns/pkg/operator/operators/klusterlet/controllers/klusterletcontroller/klusterlet_namespace_reconcile.go#L42

updated

[elgnay]

/lgtm