Skip to content

🐛 Add event when stop creating CSR because of too many. #482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

xuezhaojun
Copy link
Member

Summary

There are times when we do troubleshooting, find CSR is not triggered but no error msg in registration-agent pod logs.
It will be more friendly if we can have a event for this case.

@openshift-ci openshift-ci bot requested review from elgnay and ldpliu May 29, 2024 09:53
@xuezhaojun
Copy link
Member Author

/assign @qiujian16

Copy link

codecov bot commented May 29, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 62.71%. Comparing base (add5d45) to head (9cf997b).
Report is 1 commits behind head on main.

Files Patch % Lines
pkg/registration/clientcert/cert_controller.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #482      +/-   ##
==========================================
- Coverage   62.71%   62.71%   -0.01%     
==========================================
  Files         136      136              
  Lines       11578    11580       +2     
==========================================
+ Hits         7261     7262       +1     
- Misses       3549     3550       +1     
  Partials      768      768              
Flag Coverage Δ
unit 62.71% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@xuezhaojun xuezhaojun changed the title 🐛 Add event when stop creating CSR too many. 🐛 Add event when stop creating CSR because of too many. May 29, 2024
@xuezhaojun xuezhaojun closed this May 29, 2024
@xuezhaojun xuezhaojun reopened this May 29, 2024
Copy link
Member

@qiujian16 qiujian16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm label May 30, 2024
Copy link
Contributor

openshift-ci bot commented May 30, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiujian16, xuezhaojun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit c61895c into open-cluster-management-io:main May 30, 2024
24 of 25 checks passed
@xuezhaojun xuezhaojun deleted the add-log-when-csr-too-many branch May 30, 2024 02:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants