Skip to content

📖 Update CRD descriptions. #360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

xuezhaojun
Copy link
Member

@xuezhaojun xuezhaojun commented Feb 18, 2024

Summary

This pull request is intended to address grammar, spelling, and punctuation issues in the CRD descriptions.

Related commit in the api repo: open-cluster-management-io/api@480f8ab

@openshift-ci openshift-ci bot requested review from deads2k and qiujian16 February 18, 2024 03:18
@xuezhaojun
Copy link
Member Author

/assign @qiujian16

@xuezhaojun
Copy link
Member Author

/assign @qiujian16

Copy link

codecov bot commented Feb 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c5e210a) 61.30% compared to head (f408aed) 61.30%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #360   +/-   ##
=======================================
  Coverage   61.30%   61.30%           
=======================================
  Files         132      132           
  Lines       14032    14032           
=======================================
  Hits         8602     8602           
  Misses       4674     4674           
  Partials      756      756           
Flag Coverage Δ
unit 61.30% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@qiujian16
Copy link
Member

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm label Feb 19, 2024
Copy link
Contributor

openshift-ci bot commented Feb 19, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiujian16, xuezhaojun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 4d91239 into open-cluster-management-io:main Feb 19, 2024
@xuezhaojun xuezhaojun deleted the update-CRD-descriptions branch February 19, 2024 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants