Skip to content

⚠️ use managedclustraddon install namespace when addondeploymentconfig not set #1027

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

zhujian7
Copy link
Member

@zhujian7 zhujian7 commented Jun 6, 2025

Summary

Currently, when deploying an addonTemplate type addon, if the addondeploymentconfig is not set, we will deploy the resources into the namespace of the first deployment/daemonset defined in the addonTemplate. This PR changes to deploy the resources into the namespace of managedclusteraddon.spec.installnamespace.

Related issue(s)

Fixes #

Copy link
Contributor

openshift-ci bot commented Jun 6, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zhujian7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Jun 6, 2025
@zhujian7
Copy link
Member Author

zhujian7 commented Jun 6, 2025

/hold
Not sure if this change is necessary as we are going to deprecate the managedclusteraddon.spec.installnamespace

@qiujian16
Copy link
Member

we should use the namespace in status

Copy link

codecov bot commented Jun 6, 2025

Codecov Report

Attention: Patch coverage is 84.21053% with 6 lines in your changes missing coverage. Please review.

Project coverage is 64.18%. Comparing base (fb5ba3a) to head (3120a30).

Files with missing lines Patch % Lines
pkg/addon/templateagent/template_agent.go 82.85% 4 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1027      +/-   ##
==========================================
+ Coverage   64.13%   64.18%   +0.05%     
==========================================
  Files         196      196              
  Lines       19292    19297       +5     
==========================================
+ Hits        12373    12386      +13     
+ Misses       5894     5886       -8     
  Partials     1025     1025              
Flag Coverage Δ
unit 64.18% <84.21%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants