Skip to content

Add support for the copy template functions to the propagator #99

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

gparvin
Copy link
Member

@gparvin gparvin commented Mar 29, 2023

Adding the copyConfigMapData and the copySecretData template functions to the policy propagator.

Refs:

Adding the `copyConfigMapData` and the `copySecretData` template
functions to the policy propagator.

Refs:
 - https://issues.redhat.com/browse/ACM-2611

Signed-off-by: Gus Parvin <[email protected]>
@gparvin gparvin force-pushed the copy-configmap-secret branch from e412d84 to 5054547 Compare March 30, 2023 18:13
@gparvin gparvin requested a review from JustinKuli March 30, 2023 18:38
Copy link
Contributor

@yiraeChristineKim yiraeChristineKim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Justin mentioned already put cleanup into afterall would be better, sometimes it cleans up when spec is running so.. looks good

@openshift-ci
Copy link

openshift-ci bot commented Mar 31, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gparvin, yiraeChristineKim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [gparvin,yiraeChristineKim]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants