Add ManagedClusterLabels to hub template context #95
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/hold |
JustinKuli
force-pushed
the
4168-managedclusterlabels-in-templates
branch
2 times, most recently
from
efe0342 to
354a312
Compare
|
LGTM! There's a conflict to resolve here, though. |
JustinKuli
force-pushed
the
4168-managedclusterlabels-in-templates
branch
from
354a312 to
76df216
Compare
|
/unhold Now ready for real review! |
dhaiducek
reviewed
Mar 28, 2023
go.mod
Outdated
| @@ -90,6 +90,7 @@ require ( | |||
| ) | |||
|
|
|||
| replace ( | |||
| github.com/stolostron/go-template-utils/v3 => github.com/JustinKuli/go-template-utils/v3 v3.0.0-20230317191931-87e9558c03e6 | |||
The labels on the ManagedCluster where the policy is being propagated are now available for use in hub templates. And when the labels on the ManagedCluster change, the template will automatically be updated. Refs: - https://issues.redhat.com/browse/ACM-4168 Signed-off-by: Justin Kulikauskas <[email protected]>
Signed-off-by: Justin Kulikauskas <[email protected]>
JustinKuli
force-pushed
the
4168-managedclusterlabels-in-templates
branch
from
76df216 to
1f5c0ca
Compare
dhaiducek
approved these changes
Mar 28, 2023
| @@ -21,6 +21,7 @@ jobs: | |||
| env: | |||
| REGISTRY: localhost:5000 | |||
| strategy: | |||
| fail-fast: false | |||
There was a problem hiding this comment.
I should have known this would be in here 😉
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dhaiducek, JustinKuli The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The labels on the ManagedCluster where the policy is being propagated are now available for use in hub templates. And when the labels on the ManagedCluster change, the template will automatically be updated.
Refs: