Add the spec.copyPolicyMetadata field #91
Conversation
| // If set to false, only the policy framework specific policy labels and annotations will be copied to the | ||
| // replicated policy. | ||
| // +kubebuilder:validation:Optional | ||
| CopyPolicyMetadata *bool `json:"copyPolicyMetadata,omitempty"` |
There was a problem hiding this comment.
Note that this is a pointer to avoid setting a default in the CRD to always cause this field to be shown when unset.
Thanks for the review! I'll wait for a second +1 since it is a CRD change. |
This new field allows a replicated policy to not have labels and annotations that are not managed by the policy framework. This is useful in the case where policies are deployed with ArgoCD and you don't want them to show up in the ArgoCD UI. Additionally, the argocd.argoproj.io/compare-options annotation is now always set to IgnoreExtraneous on the replicated policies to avoid ArgoCD trying to manage the replicated policies. Relates: https://issues.redhat.com/browse/ACM-1690 Signed-off-by: mprahl <[email protected]>
mprahl
changed the title
|
@dhaiducek and @JustinKuli , I realized I had a typo in the commit subject, so I had to force push. Could you please approve it again? |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dhaiducek, mprahl The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/unhold |
This new field allows a replicated policy to not have labels and annotations that are not managed by the policy framework. This is useful in the case where policies are deployed with ArgoCD and you don't want them to show up in the ArgoCD UI.
Additionally, the argocd.argoproj.io/compare-options annotation is now always set to IgnoreExtraneous on the replicated policies to avoid ArgoCD trying to manage the replicated policies.
Relates:
https://issues.redhat.com/browse/ACM-1690