Fix reconciling a policy with a dot in its name #82
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Namespaces are required to be valid RFC 1123 DNS labels, so they do not have a `.` in their names. But that is not required for names of other objects, like this code might have assumed. So when a policy had a name like `foo.bar`, an error was occurring, which prevented the root policy from getting a status update. Refs: - https://issues.redhat.com/browse/ACM-2712 Signed-off-by: Justin Kulikauskas <[email protected]>
mprahl
approved these changes
Jan 11, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JustinKuli, mprahl The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Namespaces are required to be valid RFC 1123 DNS labels, so they do not have a
.in their names. But that is not required for names of other objects, like this code might have assumed. So when a policy had a name likefoo.bar, an error was occurring, which prevented the root policy from getting a status update.Refs:
Signed-off-by: Justin Kulikauskas [email protected]