Use HaveOccurred() for E2E error checking
#186
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dale Haiducek <[email protected]>
dhaiducek
force-pushed
the
ginkgo-fixes
branch
2 times, most recently
from
f4cb12b to
5a52f31
Compare
Signed-off-by: Dale Haiducek <[email protected]>
dhaiducek
force-pushed
the
ginkgo-fixes
branch
from
5a52f31 to
d581c85
Compare
JustinKuli
approved these changes
Feb 19, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dhaiducek, JustinKuli The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold |
dhaiducek
commented
Feb 19, 2024
|
|
||
| output, err := kubectlCmd.CombinedOutput() | ||
| if err != nil { | ||
| return string(output), fmt.Errorf("error running kubectl command: %s: %s", output, err.Error()) |
There was a problem hiding this comment.
@JustinKuli Do you think we should put the command being run also or just return the stderr message?
There was a problem hiding this comment.
Ah, it merged. Maybe another time 😆
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also adjusts
KubectlWithOutput()so that thestderrmessage is returned with the error, rather than the unhelpful "exit status 1" system error.