Skip to content

Use testcase-scoped variables #179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

dhaiducek
Copy link
Member

...because unnecessary package-level variables are a no-no.

Signed-off-by: Dale Haiducek <[email protected]>
@gparvin
Copy link
Member

gparvin commented Feb 15, 2024

/hold
in case the tests are flaky and you're still working on something, but this looks like nice cleanup work. Thanks!
/lgtm

@dhaiducek
Copy link
Member Author

/hold in case the tests are flaky and you're still working on something, but this looks like nice cleanup work. Thanks! /lgtm

Thanks! It is a flake, but doesn't seem to be one I caused. Re-running...

@dhaiducek
Copy link
Member Author

/unhold

@dhaiducek
Copy link
Member Author

@gparvin The merge is waiting for a GitHub review also.

Copy link
Member

@JustinKuli JustinKuli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent!

Copy link

openshift-ci bot commented Feb 16, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dhaiducek, JustinKuli

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [JustinKuli,dhaiducek]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants