Add partial indexes to account for null values #155
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: mprahl <[email protected]>
In Postgres 15+, NULLS NOT DISTINCT is supported so that a null value in the same column is seen as the same value. This is not standard SQL and Postgres 15 is likely too new to require. This is a workaround to include partial indexes when some null values are provided. Signed-off-by: mprahl <[email protected]>
JustinKuli
approved these changes
Dec 19, 2023
Comment on lines
+71
to
+74
| - -c | ||
| - log_statement=all | ||
| - -c | ||
| - log_destination=stderr |
There was a problem hiding this comment.
I could just check this myself I guess, but is this just a "echo all incoming requests" kind of thing?
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JustinKuli, mprahl The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Postgres 15+, NULLS NOT DISTINCT is supported so that a null value in
the same column is seen as the same value. This is not standard SQL and
Postgres 15 is likely too new to require. This is a workaround to
include partial indexes when some null values are provided.
Note that the first commit helps debug in a test/dev environment.