ACM-3299: governance-policy-propagator: Use SA for E2E #151
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JeffeyL
force-pushed
the
ACM-3299
branch
2 times, most recently
from
e6b1d5f to
08654b2
Compare
dhaiducek
requested changes
Dec 11, 2023
dhaiducek
reviewed
Dec 11, 2023
Previously, the E2E tests on PRs did not use ServiceAccounts, requiring manual updates for permissions for a code change. This change instead uses ServiceAccounts generated by Kubebuilder. Ref: https://issues.redhat.com/browse/ACM-3299 Signed-off-by: Jeffrey Luo <[email protected]>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dhaiducek, JeffeyL The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the E2E tests on PRs did not use ServiceAccounts, requiring manual updates for permissions for a code change. This change instead uses ServiceAccounts generated by Kubebuilder.
Ref: https://issues.redhat.com/browse/ACM-3299