Skip to content

Add retries to some templating related failures #149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 1, 2023
Merged

Conversation

mprahl
Copy link
Member

@mprahl mprahl commented Dec 1, 2023

In particular, after the replicated policy controller was created, multiple replicated policies for the same cluster can now be processed at the same time. This led to race conditions of each goroutine trying to create the policy encryption key for the first time.

This adds more retries to make hub templates more resilient.

Relates:
https://issues.redhat.com/browse/ACM-8744

In particular, after the replicated policy controller was created,
multiple replicated policies for the same cluster can now be processed
at the same time. This led to race conditions of each goroutine trying
to create the policy encryption key for the first time.

This adds more retries to make hub templates more resilient.

Relates:
https://issues.redhat.com/browse/ACM-8744

Signed-off-by: mprahl <[email protected]>
@mprahl mprahl requested a review from JustinKuli December 1, 2023 20:56
Copy link

openshift-ci bot commented Dec 1, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JustinKuli, mprahl

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants