Bug: 2 ansiblejobs were created when "Disabled+Manual" mode #116
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yiraeChristineKim
force-pushed
the
ACM-5644
branch
from
fb008f8 to
ecadafe
Compare
| cleanupPolicyAutomation() | ||
| }) | ||
| }) | ||
| Describe("Test manual run and diable", func() { |
There was a problem hiding this comment.
I just put this test into a separate test for fast testing
| }) | ||
| }) | ||
| Describe("Test manual run and diable", func() { | ||
| It("Change policy to disabled and create policyAutomation with disabled", func() { |
There was a problem hiding this comment.
Here start new test
JustinKuli
reviewed
Jun 15, 2023
controllers/common/ansible.go
Outdated
Comment on lines
88
to
92
| ansiblejobLen := len(ansiblejobList.Items) | ||
| // Check whether new PolicyAutomation | ||
| if ansiblejobLen == 0 { | ||
| return false, nil | ||
| } |
There was a problem hiding this comment.
Nit: this isn't a problem, but it's not necessary. If the list is empty, the loop will be skipped, and it will just return false, nil anyway.
|
|
||
| return len(ansiblejobList.Items) | ||
| }, 30, 1).Should(Equal(1)) | ||
| Describe("Test PolicyAutomation Maunul run", func() { |
There was a problem hiding this comment.
Suggested change
| Describe("Test PolicyAutomation Maunul run", func() { | |
| Describe("Test PolicyAutomation Manual run", func() { |
…l" mode Solution: Add resourceV verification Signed-off-by: Yi Rae Kim <[email protected]>
yiraeChristineKim
force-pushed
the
ACM-5644
branch
from
ecadafe to
e87c638
Compare
mprahl
approved these changes
Jun 20, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mprahl, yiraeChristineKim The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of problem:
There are two ansiblejobs created when a disabled policy is configured with "Disabled + Manual" mode in some creds.
Solution: Add resourceVersion verification
Ref: https://issues.redhat.com/browse/ACM-5644